Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SQL query planning to new crate #2345

Closed
4 tasks
Tracked by #474
andygrove opened this issue Apr 26, 2022 · 0 comments · Fixed by #2588
Closed
4 tasks
Tracked by #474

Move SQL query planning to new crate #2345

andygrove opened this issue Apr 26, 2022 · 0 comments · Fixed by #2588
Labels
enhancement New feature or request

Comments

@andygrove
Copy link
Member

andygrove commented Apr 26, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
This is a long-term goal and not possible to do today but I think it would be good to improve the separation between planning and execution over time.

Users who just want to use DataFusion for query planning would be able to add a dependency on datafusion-sql.

Describe the solution you'd like
I would like the ability to have projects just depend on datafusion-sql if they are using DataFusion as a SQL parser + query planner and are not using it for execution.

Possible steps towards doing this:

  • Move ExpressionVisitor and exprlist_to_columns from optimizer module to datafusion-expr crate
  • Move expand_wildcard and expand_qualified_wildcard from builder to expr
  • Move/copy TableReference from catalog to `sql or a common crate
  • SQL planner needs to stop using LogicalPlanBuilder (which depends on datasource and physical plan and also is not CTE-aware) - or we need to move LogicalPlanBuilder to expr, but it depends on datasource + physical plan

Describe alternatives you've considered
None

Additional context
None

@andygrove andygrove added the enhancement New feature or request label Apr 26, 2022
@andygrove andygrove changed the title Move SQL query planner to new datafusion-sql crate Move logical query planning and optimization to new crate May 7, 2022
@andygrove andygrove changed the title Move logical query planning and optimization to new crate Move logical query planning and optimization to new crate(s) May 15, 2022
@andygrove andygrove changed the title Move logical query planning and optimization to new crate(s) Move SQL query planning to new crate May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant