improve error message for invalid create table statement #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
datafusion
datafusion/src/sql/planner.rs
Outdated
| { | ||
| let plan = self.query_to_plan(query)?; | ||
| } => { | ||
| if columns.is_empty() |
There was a problem hiding this comment.
minor: I prefer match guard to if here. Just like other options(or_replace, if_not_exists, etc) are being pattern matched.
Because it feel like bit confusing to see different error messages across different create table variants.
❯ create table a;
NotImplemented("Unsupported SQL statement: CreateTable { or_replace: false, temporary: false, external: false, if_not_exists: false, name: ObjectName([Ident { value: \"a\", quote_style: None }]), columns: [], constraints: [], hive_distribution: NONE, hive_formats: Some(HiveFormat { row_format: None, storage: None, location: None }), table_properties: [], with_options: [], file_format: None, location: None, query: None, without_rowid: false, like: None }")
❯ create table if not exists a as select 1 as col1;
NotImplemented("Unsupported SQL statement: CreateTable { or_replace: false, temporary: false, external: false, if_not_exists: true, name: ObjectName([Ident { value: \"a\", quote_style: None }]), columns: [], constraints: [], hive_distribution: NONE, hive_formats: Some(HiveFormat { row_format: None, storage: None, location: None }), table_properties: [], with_options: [], file_format: None, location: None, query: Some(Query { with: None, body: Select(Select { distinct: false, top: None, projection: [ExprWithAlias { expr: Value(Number(\"1\", false)), alias: Ident { value: \"col1\", quote_style: None } }], from: [], lateral_views: [], selection: None, group_by: [], cluster_by: [], distribute_by: [], sort_by: [], having: None }), order_by: [], limit: None, offset: None, fetch: None }), without_rowid: false, like: None }")
❯ create table a(id string) as select 1 as col1;
NotImplemented("Only `CREATE TABLE table_name AS SELECT ...` statement is supported")
There was a problem hiding this comment.
Good call, I have pushed a new commit to address this.
jimexist
approved these changes
Nov 14, 2021
alamb
approved these changes
Nov 15, 2021
| "Only SELECT statements are implemented".to_string(), | ||
| )), | ||
| _ => Err(DataFusionError::NotImplemented(format!( | ||
| "Unsupported SQL statement: {:?}", |
matthewmturner
pushed a commit
to matthewmturner/arrow-datafusion
that referenced
this pull request
Nov 16, 2021
* improve error message for invalid create table statement * handle different create table cases using match
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We show
Only SELECT statements are implementedwhen user entered an invalid create table query in datafusion-cli, which is misleading.What changes are included in this PR?
Change the error message to make it match the features we have today.
Are there any user-facing changes?
no