fix: make nulls-order consistent with postgres #1344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
datafusion
xudong963
commented
Nov 20, 2021
| #[tokio::test] | ||
| async fn test_nulls_first_asc() -> Result<()> { | ||
| let mut ctx = ExecutionContext::new(); | ||
| let sql = "SELECT * FROM (VALUES (1, 'one'), (2, 'two'), (null, 'three')) AS t (num,letter) ORDER BY num"; |
There was a problem hiding this comment.
Every time I construct a test case with a value list, I think of @jimexist lol 😄
Dandandan
approved these changes
Nov 20, 2021
|
Might be good to add some tests as well to compare it with PostgreSQL (integration-tests folder)? |
OK |
alamb
approved these changes
Nov 20, 2021
There was a problem hiding this comment.
I tried it out with postgres and indeed this appears consistent
alamb=# select * from A order by a;
a
---
1
2
(3 rows)
I agree with @Dandandan that some integration tests would be nice, though probably not necessary in this case
Done, PTAL! cc @Dandandan |
alamb
approved these changes
Nov 20, 2021
| "| 1 | one |", | ||
| "+-----+--------+", | ||
| ]; | ||
| assert_batches_eq!(expected, &actual); |
houqp
approved these changes
Nov 20, 2021
|
Thanks @xudong963 ! |
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1343
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?
No