Make MemoryManager and MemoryStream public
#1664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Jan 24, 2022
| @@ -20,6 +20,6 @@ | |||
| pub mod context; | |||
| pub mod dataframe_impl; | |||
| pub(crate) mod disk_manager; | |||
| pub(crate) mod memory_manager; | |||
| pub mod memory_manager; | |||
There was a problem hiding this comment.
I also had to make MemoryManager public in #1668 -- I went with just the MemoryManager structure, but maybe making the whole module would be better 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #150 .
Rationale for this change
Make
MemoryManagerandMemoryStreampublic, make them accessible by ballista or other projects.What changes are included in this PR?
Are there any user-facing changes?