Refactor datafusion/src/physical_plan/common.rs build_file_list to take less param and reuse code #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimexist
changed the title
jimexist
changed the title
jimexist
changed the title
jimexist
commented
May 4, 2021
| @@ -389,7 +389,7 @@ impl ExecutionPlan for HashJoinExec { | |||
| num_output_rows: 0, | |||
| join_time: 0, | |||
| random_state: self.random_state.clone(), | |||
| visited_left_side: visited_left_side, | |||
| visited_left_side, | |||
There was a problem hiding this comment.
this fixes a clippy warning
There was a problem hiding this comment.
I just noticed the same thing #259
alamb
approved these changes
May 4, 2021
| @@ -389,7 +389,7 @@ impl ExecutionPlan for HashJoinExec { | |||
| num_output_rows: 0, | |||
| join_time: 0, | |||
| random_state: self.random_state.clone(), | |||
| visited_left_side: visited_left_side, | |||
| visited_left_side, | |||
There was a problem hiding this comment.
I just noticed the same thing #259
Dandandan
approved these changes
May 4, 2021
houqp
added
api change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example
Closes #123indicates that this PR will close issue #123.Closes #254
Rationale for this change
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
What changes are included in this PR?
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
Basically a new fn without the mut ref accumulator list param is added, wrapping the original one. All call sites are updated.
Are there any user-facing changes?
If there are user-facing changes then we may require documentation to be updated before approving the PR.
If there are any breaking changes to public APIs, please add the
breaking changelabel.