Fix JOINs with complex predicates in ON (split ON expressions only by AND operator)
#2534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
May 16, 2022
| FROM person \ | ||
| JOIN orders ON id = customer_id OR person.age > 30"; | ||
| let expected = "Projection: #person.id, #orders.order_id\ | ||
| \n Filter: #person.id = #orders.customer_id OR #person.age > Int64(30)\ |
alamb
changed the title
JOINs with complex predicates in ON (split ON expressions only by AND operator)
|
This is a great find. Thank you @korowa |
korowa
added a commit
to korowa/arrow-datafusion
that referenced
this pull request
May 18, 2022
MazterQyou
pushed a commit
to cube-js/arrow-datafusion
that referenced
this pull request
May 26, 2022
MazterQyou
pushed a commit
to cube-js/arrow-datafusion
that referenced
this pull request
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Close #2271.
Rationale for this change
Fix for splitting ON expression into keys and filters.
What changes are included in this PR?
At this moment
extract_join_keysrecursively called on both parts of any binary expression, thoughparse_joinconcatenates all filter expressions with AND operator. This PR changes its behaviour - recursive call occurs only in case of AND operator.Are there any user-facing changes?
Correct execution plans produced for queries with complex ON conditions (in case these conditions are supported).