Remove scan_csv methods from LogicalPlanBuilder
#2537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
changed the title
scan_csv methods from LogicalPlanBuilderscan_csv methods from LogicalPlanBuilder
andygrove
changed the title
scan_csv methods from LogicalPlanBuilderscan_csv methods from LogicalPlanBuilder
andygrove
changed the title
scan_csv methods from LogicalPlanBuilderscan_csv methods from LogicalPlanBuilder
alamb
approved these changes
May 16, 2022
There was a problem hiding this comment.
I went through the test changes carefully; Very nice @andygrove
| @@ -1236,39 +1212,17 @@ mod roundtrip_tests { | |||
|
|
|||
| #[tokio::test] | |||
| async fn roundtrip_analyze() -> Result<()> { | |||
| let schema = Schema::new(vec![ | |||
|
|
||
| roundtrip_test!(plan); | ||
|
|
||
| Ok(()) | ||
| } | ||
|
|
||
| #[ignore] // see https://github.com/apache/arrow-datafusion/issues/2546 |
There was a problem hiding this comment.
FYI other reviewers: https://github.com/apache/arrow-datafusion/issues/2546
|
Thanks for the review @alamb ... I am close to being able to move |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #2536
Rationale for this change
LogicalPlanBuildershould be in same crate asLogicalPlanLogicalPlanBuildershould not need to know about data sources & object store but justTableSourceWhat changes are included in this PR?
LogicalPlanBuildertoSessionContextroundtrip_logical_plan_custom_ctxtest datafusion-ballista#481 to fixThere will be separate PRs to remove the other scan methods (parquet, json, avro).
Are there any user-facing changes?
Yes, this changes the
LogicalPlanBuilderAPI