Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix clippy lint #259

Merged
merged 1 commit into from
May 4, 2021
Merged

fix clippy lint #259

merged 1 commit into from
May 4, 2021

Conversation

alamb
Copy link
Contributor

@alamb alamb commented May 4, 2021

Rationale for this change

When I run clippy locally, I get the following warning. This PR fixes it.

error: redundant field names in struct initialization
   --> datafusion/src/physical_plan/hash_join.rs:392:13
    |
392 |             visited_left_side: visited_left_side,
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `visited_left_side`
    |
    = note: `-D clippy::redundant-field-names` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

What changes are included in this PR?

fix clippy lint error

Are there any user-facing changes?

no

@alamb
Copy link
Contributor Author

alamb commented May 4, 2021

@Dandandan Dandandan merged commit 5f6024d into apache:master May 4, 2021
@Dandandan
Copy link
Contributor

Cool, let's merge this @alamb .

Not sure why the clippy wasn't caught by the github CI workflow?

@Dandandan
Copy link
Contributor

Dandandan commented May 4, 2021

Ah I am seeing it is explicitly allowed:

cargo clippy --all-targets --workspace -- -D warnings -A clippy::redundant_field_names

Bit weird that this is set on a global level like this, I think we should change that.

@alamb alamb deleted the alamb/clippy branch May 4, 2021 22:16
@houqp houqp added the datafusion Changes in the datafusion crate label Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datafusion Changes in the datafusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants