Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable redundant_field_names clippy lint #261

Merged
merged 1 commit into from
May 5, 2021

Conversation

Dandandan
Copy link
Contributor

@Dandandan Dandandan commented May 4, 2021

Which issue does this PR close?

Closes #260

Rationale for this change

This lint doesn't seem to cause warnings in our code. If we have some false positives, we should not put it here but on a more granular (line/code block/module/project) level, so the warnings locally reflect the CI.
I am not sure why it was configured like this, maybe because of some false positives.

What changes are included in this PR?

Remove the "allow" on the lint

Are there any user-facing changes?

No

@codecov-commenter
Copy link

Codecov Report

Merging #261 (a3a0efc) into master (5f6024d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #261   +/-   ##
=======================================
  Coverage   76.80%   76.80%           
=======================================
  Files         133      133           
  Lines       23284    23284           
=======================================
  Hits        17884    17884           
  Misses       5400     5400           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f6024d...a3a0efc. Read the comment docs.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe there were false positives in other parts of the arrow codebase as well

@alamb
Copy link
Contributor

alamb commented May 5, 2021

Thanks @Dandandan

@alamb alamb merged commit a9eac57 into apache:master May 5, 2021
@houqp houqp added ballista datafusion Changes in the datafusion crate labels Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datafusion Changes in the datafusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable redundant_field_names clippy lint
4 participants