MINOR: Implement serde for join filter #2649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@korowa fyi |
tustvold
approved these changes
May 29, 2022
| .filter | ||
| .as_ref() | ||
| .map(|expr| parse_expr(expr, ctx)) | ||
| .map_or(Ok(None), |v| v.map(Some))?; |
There was a problem hiding this comment.
Maybe https://doc.rust-lang.org/std/option/enum.Option.html#method.transpose ? I'm having a hard time figuring out what the types are though so could be mistaken
There was a problem hiding this comment.
Transpose seems to be appropriate -- I used this map_or call in ballista for conversion from Option<Result> to Result<Option>
There was a problem hiding this comment.
I copied the code over from Ballista and am not too familiar with what is going on here. @korowa would you mind updating this in a follow on PR?
alamb
approved these changes
May 30, 2022
There was a problem hiding this comment.
One copy of serialization for the win! Thank you @andygrove
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Ballista had this change in its copy of serde and Ballista now delegates to datafusion-proto for logical plan serde so we need this change here.
What changes are included in this PR?
Add JoinNode::filter
Are there any user-facing changes?
No
Does this PR break compatibility with Ballista?
No