-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add param validation for datafusion-cli #284
Conversation
|
|
|
518fb43
to
5094b09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jimexist -- this looks great!
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Codecov Report
@@ Coverage Diff @@
## master #284 +/- ##
==========================================
- Coverage 76.19% 76.16% -0.03%
==========================================
Files 140 140
Lines 23595 23603 +8
==========================================
Hits 17978 17978
- Misses 5617 5625 +8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @jimexist . This looks good. 👍
Thanks @jimexist !! |
Which issue does this PR close?
Closes #283.
Rationale for this change
More specific error messages help users understand how to fix the problem
Are there any user-facing changes?
better error messages