Simplify math expression code (use unary kernel) #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dandandan
commented
May 10, 2021
| @@ -631,7 +631,7 @@ async fn sqrt_f32_vs_f64() -> Result<()> { | |||
| // sqrt(f32)'s plan passes | |||
| let sql = "SELECT avg(sqrt(c11)) FROM aggregate_test_100"; | |||
| let actual = execute(&mut ctx, sql).await; | |||
| let expected = vec![vec!["0.6584408485889435"]]; | |||
| let expected = vec![vec!["0.6584407806396484"]]; | |||
There was a problem hiding this comment.
Small diff, since we avoid as f64 now.
Dandandan
commented
May 10, 2021
| Some(array) => compute_op!(array, $FUNC, $TYPE), | ||
| Some(array) => { | ||
| let res: $TYPE = | ||
| arrow::compute::kernels::arity::unary(array, |x| x.$FUNC()); |
There was a problem hiding this comment.
This avoids creating intermediate Vec and uses the (efficient) unary kernel
Merged
|
🎉 |
houqp
added
datafusion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #308
Rationale for this change
Simplifies code, probably is faster too. Also involves one cast less which causes more rounding errors.
What changes are included in this PR?
Use
arity::unaryfunction to simplify math expression codeAre there any user-facing changes?
No