Support COUNT(DISTINCT timestamps) #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! I'm pretty new to rust and this project so might have missed it but are there any tests I should add to? |
|
Hey @charlibot thanks for opening this PR - awesome.
Or with some more values to check whether the number of distinct values are calculated correctly. Currently we have some end-to-end tests in |
|
Hey @Dandandan, thanks for the pointer. I'll try to add that in tomorrow |
alamb
changed the title
alamb
approved these changes
May 12, 2021
There was a problem hiding this comment.
This looks great to me. Thank you @charlibot and thanks for adding the test.
| @@ -1959,6 +1959,19 @@ async fn to_timestamp() -> Result<()> { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| #[tokio::test] | |||
Dandandan
approved these changes
May 12, 2021
houqp
added
datafusion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #314 .
What changes are included in this PR?
Handles
DataType::TimestampinScalarValue::Listwith a custom macrobuild_timestamp_listthat takes the time unit and timezone.Are there any user-facing changes?