Use NullArray to Pass row count to ScalarFunctions that take 0 arguments #328
Conversation
There was a problem hiding this comment.
FWIW I think this looks good, and is the consensus direction for this feature:
(see #303 (comment))
The tests for random() will cover the code in this PR I think.
I had one comment regarding From vs TryFrom but then I think it is ready
jimexist
force-pushed
the
fix-305
branch
2 times, most recently
from
a3c7acc
to
efcdd4a
Compare
Codecov Report
@@ Coverage Diff @@
## master #328 +/- ##
=======================================
Coverage 75.72% 75.72%
=======================================
Files 143 143
Lines 23832 23840 +8
=======================================
+ Hits 18046 18054 +8
Misses 5786 5786
Continue to review full report at Codecov.
|
| impl BuiltinScalarFunction { | ||
| /// an allowlist of functions to take zero arguments, so that they will get special treatment | ||
| /// while executing. | ||
| fn supports_zero_argument(&self) -> bool { |
There was a problem hiding this comment.
had to add this whitelist because vararg funcs like array will not accept 0 args
alamb
changed the title
|
I agree -- thanks again @jimexist -- great stuff |
houqp
added
datafusion
Which issue does this PR close?
fix 305 by using a null array as param for zero param functions
Closes #305
Rationale for this change
in case of a zero param function we'll have a rather hacky way to pass in the batch num_rows param so that the functions wrapped can be generative the correct result
What changes are included in this PR?
Similar to #307 but use a null array instead
Are there any user-facing changes?