-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SQL planner to support multibyte column names #357
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😀 emoji support! 💯
Oh, sorry, I made a mistake in the test case. |
Looks great @agatan - thank you! I just started CI on this PR and once we get a clean run I think this one is ready to merge |
Codecov Report
@@ Coverage Diff @@
## master #357 +/- ##
==========================================
+ Coverage 75.72% 75.85% +0.12%
==========================================
Files 143 143
Lines 23910 23814 -96
==========================================
- Hits 18107 18064 -43
+ Misses 5803 5750 -53
Continue to review full report at Codecov.
|
@agatan can you please fix the clippy error: https://github.com/apache/arrow-datafusion/pull/357/checks?check_run_id=2620378740
|
Thank you! I just fixed it now. |
Which issue does this PR close?
Closes #356
Rationale for this change
Please refer #356 for more detail.
What changes are included in this PR?
Slicing string will cause panic if the boundary is not correct as UTF-8.
To check if the first character is '@' or not, we should use
s.chars().nth(0)
instead of&s[0..1]
.Are there any user-facing changes?
No.