Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TPC-H benchmark to show physical plan when debug mode is enabled #386

Merged
merged 2 commits into from
May 24, 2021

Conversation

andygrove
Copy link
Member

Which issue does this PR close?

Closes #385 .

Rationale for this change

When we run the benchmarks with --debug we see the logical plan and optimized logical plan but we do not see the physical plan. This PR updates debug mode to also show the physical plan.

What changes are included in this PR?

Are there any user-facing changes?

No

@andygrove
Copy link
Member Author

Windows build failing with:

rustup: D:\a\_temp\297de9db-5464-4aa4-af8d-ef568eeef2fe.ps1:3
Line |
   3 |  rustup default stable
     |  ~~~~~~
     | The term 'rustup' is not recognized as a name of a cmdlet, function, script file, or executable
     | program. Check the spelling of the name, or if a path was included, verify that the path is correct
     | and try again.

@codecov-commenter
Copy link

codecov-commenter commented May 22, 2021

Codecov Report

Merging #386 (d3f5d16) into master (db4f098) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

❗ Current head d3f5d16 differs from pull request most recent head a149dc4. Consider uploading reports for the commit a149dc4 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #386      +/-   ##
==========================================
- Coverage   74.94%   74.93%   -0.01%     
==========================================
  Files         146      146              
  Lines       24314    24317       +3     
==========================================
+ Hits        18221    18222       +1     
- Misses       6093     6095       +2     
Impacted Files Coverage Δ
benchmarks/src/bin/tpch.rs 30.84% <33.33%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db4f098...a149dc4. Read the comment docs.

Copy link
Contributor

@Dandandan Dandandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Dandandan
Copy link
Contributor

Windows CI failure is unrelated, was happening in other PRs too.

@alamb
Copy link
Contributor

alamb commented May 23, 2021

I restared the windows CI check -- hopefully we'll get a passing run

@andygrove andygrove merged commit 7359e4b into apache:master May 24, 2021
@houqp houqp added the datafusion Changes in the datafusion crate label Jul 29, 2021
@andygrove andygrove deleted the bench-phys-plan branch February 6, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datafusion Changes in the datafusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataFusion benchmarks should show physical plan when debug is enabled
5 participants