Use 4.x arrow-rs from crates.io rather than git sha #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
added
enhancement
alamb
changed the title
Dandandan
approved these changes
May 23, 2021
Codecov Report
@@ Coverage Diff @@
## master #395 +/- ##
=======================================
Coverage 74.94% 74.94%
=======================================
Files 146 146
Lines 24314 24314
=======================================
Hits 18221 18221
Misses 6093 6093 Continue to review full report at Codecov.
|
andygrove
approved these changes
May 24, 2021
jorgecarleitao
approved these changes
May 24, 2021
|
🎉 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #393
Rationale for this change
Currently datafusion relies on a git sha of the arrow-rs crate. Historically this was required to get updates on a more frequent basis than every quarter when Arrow did major releases. With apache/arrow-rs#292 we are implementing biweekly arrow releases.
This also means prior to this PR that any project that uses datafusion and arrow together requires pinning arrow-rs to the exact same gitsha.
What changes are included in this PR?
Pin to
arrow-rs"version 4.0"However, given the way cargo interprets versions, this (somewhat confusingly) means the latest "4.x" release.
You can see that 4.1 (the most recently released version of arrow-rs) is used by doing something like
Are there any user-facing changes?
Yes -- the version of arrow-rs used by dependent projects needs to be updated to be 4.0 (or some variant) as well. However, this is no different than what has happened previously when we updated the git sha (dependent crates needed to follow the sha exactly).
This should make future datafusion upgrades easier as arrow dependent versions will only need to be updated on major releases, not each datafusion release