Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update more docs and also the developer.md doc #414

Merged
merged 2 commits into from
May 26, 2021

Conversation

jimexist
Copy link
Member

@jimexist jimexist commented May 24, 2021

Which issue does this PR close?

follow up on #421
related #415

Rationale for this change

update the developer md file

What changes are included in this PR?

Are there any user-facing changes?

@jimexist
Copy link
Member Author

Maybe we need to merge the other one first as it automatically formats code already

@codecov-commenter
Copy link

Codecov Report

Merging #414 (16e5fd5) into master (7359e4b) will not change coverage.
The diff coverage is n/a.

❗ Current head 16e5fd5 differs from pull request most recent head 2174d0b. Consider uploading reports for the commit 2174d0b to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #414   +/-   ##
=======================================
  Coverage   74.85%   74.85%           
=======================================
  Files         146      146           
  Lines       24498    24498           
=======================================
  Hits        18339    18339           
  Misses       6159     6159           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7359e4b...2174d0b. Read the comment docs.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks @jimexist

@alamb alamb merged commit b382829 into apache:master May 26, 2021
@jimexist jimexist deleted the update-more-docs branch May 28, 2021 12:45
@houqp houqp added datafusion Changes in the datafusion crate documentation Improvements or additions to documentation labels Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datafusion Changes in the datafusion crate documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants