Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Error Handling and Readibility for downcasting Float32Array, Float64Array, StringArray #4244

Merged
merged 8 commits into from
Nov 17, 2022
Merged

Improve Error Handling and Readibility for downcasting Float32Array, Float64Array, StringArray #4244

merged 8 commits into from
Nov 17, 2022

Conversation

retikulum
Copy link
Contributor

@retikulum retikulum commented Nov 16, 2022

Which issue does this PR close?

Part of #3152.

Rationale for this change

This is the new PR of improving downcasting to Float32Array, Float64Array, StringArray

What changes are included in this PR?

  • as_float64_array, as_float32_array, as_string_array is created in datafusion\common\src\cast.rs
  • Refactor parts where following lines are used:
as_any().downcast_ref::<Float32Array>().unwrap()
as_any().downcast_ref::<Float64Array>().unwrap()
as_any().downcast_ref::<StringArray>().unwrap()
as_string_array()

Are there any user-facing changes?

I am not sure about it.

@github-actions github-actions bot added core Core DataFusion crate physical-expr Physical Expressions labels Nov 16, 2022
@retikulum retikulum changed the title Improve Error Handling and Readibility for downcasting Float32Array, Float32Array, StringArray Improve Error Handling and Readibility for downcasting Float32Array, Float64Array, StringArray Nov 16, 2022
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @retikulum -- thank you very much

Copy link
Contributor

@liukun4515 liukun4515 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liukun4515 liukun4515 merged commit f4996b9 into apache:master Nov 17, 2022
@ursabot
Copy link

ursabot commented Nov 17, 2022

Benchmark runs are scheduled for baseline = 5de9709 and contender = f4996b9. f4996b9 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@retikulum retikulum deleted the 3152_improve_downcast_float_arrays branch November 17, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate physical-expr Physical Expressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants