-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Error Handling and Readibility for downcasting Float32Array
, Float64Array
, StringArray
#4244
Improve Error Handling and Readibility for downcasting Float32Array
, Float64Array
, StringArray
#4244
Conversation
Float32Array
, Float32Array
, StringArray
Float32Array
, Float64Array
, StringArray
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @retikulum -- thank you very much
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Benchmark runs are scheduled for baseline = 5de9709 and contender = f4996b9. f4996b9 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Part of #3152.
Rationale for this change
This is the new PR of improving downcasting to
Float32Array
,Float64Array
,StringArray
What changes are included in this PR?
as_float64_array
,as_float32_array
,as_string_array
is created indatafusion\common\src\cast.rs
Are there any user-facing changes?
I am not sure about it.