Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teach optimizer that CoalesceBatchesExec does not destroy output order #4332

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Nov 22, 2022

Which issue does this PR close?

Closes #4331

Rationale for this change

See #4331

What changes are included in this PR?

Teach optimizer that CoalesceBatchesExec does not destroy output order

Are these changes tested?

Yes

Are there any user-facing changes?

BasicEnforcement will not add unecessary SortExecs

@github-actions github-actions bot added the core Core DataFusion crate label Nov 22, 2022
@alamb
Copy link
Contributor Author

alamb commented Nov 23, 2022

i just need to figure out how to write a test for this PR and it will be ready

@mingmwang
Copy link
Contributor

I think you can construct a UT to test and verify a sorted input stream is still keep sorted after CoalesceBatchesExec


// The optimizer should not add an additional SortExec as the
// data is already sorted
let expected = &[
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the test (that mimics my usecase in IOx) -- without the changes in this PR this test fails (as there is a SortExec present)

@alamb alamb marked this pull request as ready for review November 28, 2022 14:52
@alamb alamb merged commit a31b44e into apache:master Nov 28, 2022
@ursabot
Copy link

ursabot commented Nov 28, 2022

Benchmark runs are scheduled for baseline = dafd957 and contender = a31b44e. a31b44e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb alamb deleted the alamb/coalsce_is_sorted branch November 28, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CoalesceBatchesExec reports no ordering
4 participants