Clean the code in limit.rs.
#4391
Conversation
|
cc @jackwener |
| /// A Limit stream skips `skip` rows, and then fetch up to `fetch` rows. | ||
| struct LimitStream { | ||
| /// The number of rows to skip | ||
| /// The remaining number of rows to skip | ||
| skip: usize, |
There was a problem hiding this comment.
The meaning ofskip and fetch has changed, we should rename them.
There was a problem hiding this comment.
Oh, I see this was not yet done -- @HaoYang670 can you please do this as a follow on PR? If you don't have time I will do so myself
There was a problem hiding this comment.
Sure, I'll file a follow-up.
| Poll::Ready(Some(Ok(batch))) => { | ||
| if batch.num_rows() > 0 && self.skip == 0 { | ||
| break poll; | ||
| } else { | ||
| // continue to poll input stream | ||
| } |
|
Benchmark runs are scheduled for baseline = a31b44e and contender = 52e198e. 52e198e is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Signed-off-by: remzi 13716567376yh@gmail.com
Which issue does this PR close?
None.
Rationale for this change
What changes are included in this PR?
current_skipandcurrent_fetchfromLimitStreambecause they are redundant.truncate_batchand merge its functionality intostream_limit. Becausetruncate_batchis not performant whenrow_num == 0and it's only used instream_limitAre these changes tested?
Current tests cover the changes.
Are there any user-facing changes?
No.