Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix window aggregation with alias and add integration test case #454

Merged
merged 2 commits into from
Jun 2, 2021

Conversation

jimexist
Copy link
Member

@jimexist jimexist commented May 31, 2021

Which issue does this PR close?

fix window aggregation with alias

Closes #455.

Rationale for this change

What changes are included in this PR?

  • fix by rebasing exprs
  • add integration test cases

Are there any user-facing changes?

@jimexist jimexist changed the title fix window aggregation with alias fix window aggregation with alias and add integration test case May 31, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #454 (7cb2f1c) into master (c8ab5a4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #454   +/-   ##
=======================================
  Coverage   75.30%   75.30%           
=======================================
  Files         152      152           
  Lines       25275    25279    +4     
=======================================
+ Hits        19033    19037    +4     
  Misses       6242     6242           
Impacted Files Coverage Δ
datafusion/src/logical_plan/builder.rs 90.47% <100.00%> (ø)
datafusion/src/sql/planner.rs 84.10% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8ab5a4...7cb2f1c. Read the comment docs.

@alamb
Copy link
Contributor

alamb commented Jun 1, 2021

I am loving the integration test harness . Thanks @jimexist 👍

Copy link
Contributor

@Dandandan Dandandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Dandandan Dandandan merged commit c3fc0c7 into apache:master Jun 2, 2021
@jimexist jimexist deleted the fix-window-alias branch June 2, 2021 07:37
@houqp houqp added bug Something isn't working datafusion Changes in the datafusion crate labels Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working datafusion Changes in the datafusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

window function with alias is not properly rebased
5 participants