Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Reduce even more redundancy creating window_agg in sort_enforcement tests #4945

Merged
merged 2 commits into from
Jan 18, 2023

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jan 17, 2023

Which issue does this PR close?

re #4943

Rationale for this change

Implement suggestion from @mustafasrepo in #4928 (comment)

What changes are included in this PR?

factor out window agg exec creation into a function as part of test

Are these changes tested?

all tests

Are there any user-facing changes?

@github-actions github-actions bot added the core Core DataFusion crate label Jan 17, 2023
@alamb alamb changed the title Minor: Reduce redundancy creating window_agg in sort_enforcement tests Minor: Reduce even more redundancy creating window_agg in sort_enforcement tests Jan 17, 2023
@mustafasrepo
Copy link
Contributor

LGTM!.

@alamb alamb merged commit 64fa312 into apache:master Jan 18, 2023
@ursabot
Copy link

ursabot commented Jan 18, 2023

Benchmark runs are scheduled for baseline = 896fd3f and contender = 64fa312. 64fa312 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb alamb deleted the alamb/refactor_enforce_sort_tests2 branch July 26, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants