Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not resort inputs to UnionExec if they are already sorted #4946

Merged
merged 2 commits into from
Jan 17, 2023
Merged

Do not resort inputs to UnionExec if they are already sorted #4946

merged 2 commits into from
Jan 17, 2023

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jan 17, 2023

Which issue does this PR close?

Closes #4943

Rationale for this change

See #4943 -- basically the issue is that EnforceSorting pass is adding an unecessary sort to UnionExec at some times

What changes are included in this PR?

  1. Implement UnionExec::maintains_input_order as suggested by @mustafasrepo EnforceSorting resorts the inout of UnionExec unnecessarily #4943 (comment)
  2. Add test

Are these changes tested?

Yes

Are there any user-facing changes?

Bug fix (though I don't know if any SQL queries would be affected by this)

@alamb alamb marked this pull request as draft January 17, 2023 14:03
@alamb
Copy link
Contributor Author

alamb commented Jan 17, 2023

Draft as it still has a bunch of debugging that I need to remove

@github-actions github-actions bot added the core Core DataFusion crate label Jan 17, 2023
alamb
alamb commented Jan 17, 2023
View reviewed changes
datafusion/core/src/physical_plan/union.rs
@@ -247,6 +247,30 @@ impl ExecutionPlan for UnionExec {
}
}

fn maintains_input_order(&self) -> bool {
let first_input_ordering = self.inputs[0].output_ordering();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is basically exactly what was suggested by @mustafasrepo with a slightly modified comment

@alamb alamb changed the title Do not resort inputs to Union if they are already sorted Do not resort inputs to UnionExec if they are already sorted Jan 17, 2023
@alamb alamb marked this pull request as ready for review January 17, 2023 14:11
@alamb alamb mentioned this pull request Jan 17, 2023
Closed
@mustafasrepo
Copy link
Contributor

LGTM!.

This was referenced Jan 17, 2023
Closed
Closed
@alamb alamb merged commit 279440b into apache:master Jan 17, 2023
@alamb alamb deleted the alamb/do_not_resort branch January 17, 2023 18:23
@ursabot
Copy link

ursabot commented Jan 17, 2023

Benchmark runs are scheduled for baseline = 84ba3c2 and contender = 279440b. 279440b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core Core DataFusion crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EnforceSorting resorts the inout of UnionExec unnecessarily
3 participants
@alamb @mustafasrepo @ursabot