Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infer values for inserts #4977

Merged
merged 5 commits into from
Jan 23, 2023

Conversation

avantgardnerio
Copy link
Contributor

Which issue does this PR close?

Closes #4976.

Rationale for this change

Described in issue.

What changes are included in this PR?

Type inference for insert into values ($1) style queries.

Are these changes tested?

Yes, with an integration test.

Are there any user-facing changes?

Type inference should work on more parameterized queries.

@github-actions github-actions bot added the sql SQL Planner label Jan 18, 2023
@avantgardnerio avantgardnerio changed the title Infer values for updates Infer values for inserts Jan 18, 2023
datafusion/sql/src/statement.rs Outdated Show resolved Hide resolved
@alamb
Copy link
Contributor

alamb commented Jan 20, 2023

Thanks @avantgardnerio

@alamb
Copy link
Contributor

alamb commented Jan 23, 2023

I think this is ready to go but I left some suggestions -- I'll wait another day or so for @avantgardnerio to respond and if not I'll plan to merge this

Brent Gardner and others added 2 commits January 23, 2023 08:45
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
@avantgardnerio
Copy link
Contributor Author

I think this is ready to go but I left some suggestions -- I'll wait another day or so for @avantgardnerio to respond and if not I'll plan to merge this

I was out for the weekend. I'm back and applied your suggestion. When tests pass I'll merge unless any objections come up before then.

@avantgardnerio avantgardnerio merged commit 5d4038a into apache:master Jan 23, 2023
@avantgardnerio avantgardnerio deleted the bg_infer_insert branch January 23, 2023 17:20
@ursabot
Copy link

ursabot commented Jan 23, 2023

Benchmark runs are scheduled for baseline = 624f02d and contender = 5d4038a. 5d4038a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb
Copy link
Contributor

alamb commented Jan 23, 2023

Thanks @avantgardnerio !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sql SQL Planner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infer prepared statement parameter types for insert queries with values clauses
4 participants