-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infer values for inserts #4977
Infer values for inserts #4977
Conversation
Thanks @avantgardnerio |
I think this is ready to go but I left some suggestions -- I'll wait another day or so for @avantgardnerio to respond and if not I'll plan to merge this |
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
I was out for the weekend. I'm back and applied your suggestion. When tests pass I'll merge unless any objections come up before then. |
Benchmark runs are scheduled for baseline = 624f02d and contender = 5d4038a. 5d4038a is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Thanks @avantgardnerio ! |
Which issue does this PR close?
Closes #4976.
Rationale for this change
Described in issue.
What changes are included in this PR?
Type inference for
insert into values ($1)
style queries.Are these changes tested?
Yes, with an integration test.
Are there any user-facing changes?
Type inference should work on more parameterized queries.