-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add datafusion::test_util, resolve test data paths without env vars #498
Conversation
Codecov Report
@@ Coverage Diff @@
## master #498 +/- ##
==========================================
+ Coverage 75.84% 75.97% +0.12%
==========================================
Files 153 155 +2
Lines 25876 26438 +562
==========================================
+ Hits 19626 20086 +460
- Misses 6250 6352 +102
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mluts ! I tried this out locally and it works well.
git clone git@github.com:mluts/arrow-datafusion.git
cd arrow-datafusion/
git checkout resolve_test_data_paths
unset PARQUET_TEST_DATA
unset ARROW_TEST_DATA
cargo run --example csv_sql
# failed, but told me to run following command
git submodule update --init
# passes!!
cargo run --example csv_sql
It looks like there are a few linting / test errors, but after that is fixed I think this PR is ready to go:
---- src\datasource\csv.rs - datasource::csv (line 24) stdout ----
error[E0433]: failed to resolve: unresolved import
--> src\datasource\csv.rs:28:23
|
7 | let testdata = crate::test_util::arrow_test_data();
| ^^^^^^^^^
| |
| unresolved import
| help: a similar path exists: `datafusion::test_util`
075056a
to
177cdc0
Compare
Managed to fix all the checks, yay 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mluts looks good!
Which issue does this PR close?
Closes #467
Rationale for this change
What changes are included in this PR?
Just ported the code from
apache/arrow-rs
Are there any user-facing changes?
Simplified "Examples" section & running tests 🙂