Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure insert projections are of correct type #5049

Merged
merged 2 commits into from
Jan 24, 2023

Conversation

avantgardnerio
Copy link
Contributor

Which issue does this PR close?

Works-around #5046.

Rationale for this change

Described in issue

What changes are included in this PR?

Casts from values clause types to insert table types.

Are these changes tested?

Yes, with an integration test.

Are there any user-facing changes?

No - I don't think anyone is using the insert/update/delete plans yet, and if they are this is probably an improvement.

@github-actions github-actions bot added the sql SQL Planner label Jan 24, 2023
@alamb
Copy link
Contributor

alamb commented Jan 24, 2023

FYI any "no space left on device" CI errors should be fixed by merging up from master to get #5047

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@avantgardnerio
Copy link
Contributor Author

It's approved, tests pass, and it's not a big breaking thing, so I'll just go ahead and merge it.

@avantgardnerio avantgardnerio merged commit c313601 into apache:master Jan 24, 2023
@avantgardnerio avantgardnerio deleted the bg_cast branch January 24, 2023 20:15
@ursabot
Copy link

ursabot commented Jan 24, 2023

Benchmark runs are scheduled for baseline = 13dfdd6 and contender = c313601. c313601 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sql SQL Planner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants