Retain schema order in projection #5053
Conversation
| let assign_map = assignments | ||
| .iter() | ||
| .map(|assign| { | ||
| let col_name: &Ident = assign |
There was a problem hiding this comment.
I know this PR didn't add it, but the use of last seems somewhat wrong here -- maybe https://github.com/apache/arrow-datafusion/blob/cb05490df1ed27cd90d904296b7866187c6e737b/datafusion/sql/src/planner.rs#L333 or something would work 🤔
There was a problem hiding this comment.
This is actually looking for the column name - we know the table name already. Is there an equivalent for columns?
Meta-question: is there a method for discoverability of these functions? I often assume there is a helper out there somewhere but struggle to find it...
|
Benchmark runs are scheduled for baseline = f627ed9 and contender = 43aca89. 43aca89 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #5052.
Rationale for this change
Described in issue.
What changes are included in this PR?
Removal of
BTreeMapAre these changes tested?
Yes, they were covered by a previous test.
Are there any user-facing changes?
Fields will be returned in a new order. This should be okay because no one is using update yet, and if they were they must have been tolerating random orders.