-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor: Fix doc links and typos #5225
Conversation
@@ -84,6 +84,8 @@ pub enum RewriteRecursion { | |||
/// # See Also: | |||
/// * [`Expr::accept`] to drive a rewriter through an [`Expr`] | |||
/// * [`rewrite_expr`]: For rewriting an [`Expr`] using functions | |||
/// | |||
/// [`Expr::accept`]: crate::expr_visitor::ExprVisitable::accept |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this isn't the right link, but i couldn't figure out how to link to the Expr
method implementation instead of just the ExprVisitable
trait method itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, it is better than a broken link -- thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me -- thank you so much @Jefffrey for the contribution
@@ -84,6 +84,8 @@ pub enum RewriteRecursion { | |||
/// # See Also: | |||
/// * [`Expr::accept`] to drive a rewriter through an [`Expr`] | |||
/// * [`rewrite_expr`]: For rewriting an [`Expr`] using functions | |||
/// | |||
/// [`Expr::accept`]: crate::expr_visitor::ExprVisitable::accept |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, it is better than a broken link -- thank you!
Benchmark runs are scheduled for baseline = 8f3c8c3 and contender = eda875b. eda875b is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
n/a
Rationale for this change
Fixing broken links that caused warnings when running
cargo doc
. Also fix some typosWhat changes are included in this PR?
Are these changes tested?
cargo doc
no longer generates warningsAre there any user-facing changes?