refactor: correct the implementation of all_schemas()
#5236
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5192.
Rationale for this change
Currently, all_schema() can return schema of child of child. (due to recursively call
all_schema()
)But, plan shouldn't get schema of child of child (or child of child of child of child ......).
It should just get info of itself and children.
For example
join shouldn't get schema of
B
.So, I refactor this implementation, remove recursion.
What changes are included in this PR?
Just return children schema and itself schema
Are these changes tested?
Are there any user-facing changes?