Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: nicer error messages for cli, use display format rather than debug #5329

Merged

Conversation

kmitchener
Copy link
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

Better user experience

What changes are included in this PR?

Instead of:

❯ select not_a_column;
SchemaError(FieldNotFound { field: Column { relation: None, name: "not_a_column" }, valid_fields: [] })

it's

❯ select not_a_column;
Schema error: No field named 'not_a_column'.

Are these changes tested?

Are there any user-facing changes?

datafusion-cli uses the nicely formatted error messages already available rather than debug format for errors

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kmitchener ! This is a nice improvement

@alamb alamb merged commit 6ec2544 into apache:main Feb 18, 2023
@ursabot
Copy link

ursabot commented Feb 18, 2023

Benchmark runs are scheduled for baseline = 27b15fd and contender = 6ec2544. 6ec2544 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

jiangzhx pushed a commit to jiangzhx/arrow-datafusion that referenced this pull request Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants