Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor: remove useless .get() #5336

Merged
merged 1 commit into from
Feb 20, 2023
Merged

minor: remove useless .get() #5336

merged 1 commit into from
Feb 20, 2023

Conversation

jackwener
Copy link
Member

Which issue does this PR close?

N/A

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the optimizer Optimizer rules label Feb 19, 2023
Dandandan
Dandandan reviewed Feb 19, 2023
View reviewed changes
datafusion/optimizer/src/propagate_empty_relation.rs Outdated
let right = inputs.get(1).unwrap();

let left_empty = match left {
let left_empty = match inputs[0] {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also match on inputs directly I think.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of on the length

Copy link
Member Author

@jackwener jackwener Feb 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved it. thanks @Dandandan

metesynnada
metesynnada reviewed Feb 19, 2023
View reviewed changes
Copy link
Contributor

@metesynnada metesynnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Dandandan Dandandan merged commit ae89960 into apache:main Feb 20, 2023
@Dandandan
Copy link
Contributor

Thanks @jackwener

@ursabot
Copy link

ursabot commented Feb 20, 2023

Benchmark runs are scheduled for baseline = db4f998 and contender = ae89960. ae89960 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

jiangzhx pushed a commit to jiangzhx/arrow-datafusion that referenced this pull request Feb 24, 2023
@jackwener @jiangzhx
minor: remove useless .get() (apache#5336)
deb3bdb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metesynnada metesynnada metesynnada left review comments

@Dandandan Dandandan Dandandan approved these changes

Assignees
No one assigned
Labels
optimizer Optimizer rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jackwener @Dandandan @ursabot @metesynnada