Cleanup Repartition Exec code #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Jun 10, 2021
| channels.insert(partition, (sender, receiver)); | ||
| } | ||
| // Use fixed random state | ||
| let random = ahash::RandomState::with_seeds(0, 0, 0, 0); | ||
|
|
||
| // launch one async task per *input* partition | ||
| for i in 0..num_input_partitions { | ||
| let random_state = random.clone(); |
There was a problem hiding this comment.
All of this code was moved to pull_from_input
andygrove
approved these changes
Jun 11, 2021
Dandandan
approved these changes
Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The body of RepartitionExec::execute is long and highly indented, and has a bunch of metrics related code that obscures how it works, in my opinion.
What changes are included in this PR?
As suggested by @tustvold in #521 (comment), attempt to make the code clearer and error conditions easier to reason about by:
Changes:
RepartitionMetricsstruct for convenienceSQLMetric::add_elapsedand reduced duplicationI still think the metrics could still be made better, and I hope to work on that at a later date.
Are there any user-facing changes?
No