Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turn on clippy rule for needless borrow #545

Merged
merged 3 commits into from
Jun 13, 2021

Conversation

jimexist
Copy link
Member

@jimexist jimexist commented Jun 12, 2021

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@codecov-commenter
Copy link

Codecov Report

Merging #545 (f14084a) into master (ad70a1e) will decrease coverage by 0.02%.
The diff coverage is 84.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #545      +/-   ##
==========================================
- Coverage   76.13%   76.11%   -0.03%     
==========================================
  Files         156      156              
  Lines       27032    27025       -7     
==========================================
- Hits        20582    20571      -11     
- Misses       6450     6454       +4     
Impacted Files Coverage Δ
...lista/rust/core/src/serde/logical_plan/to_proto.rs 61.41% <0.00%> (+0.07%) ⬆️
ballista/rust/executor/src/flight_service.rs 0.00% <ø> (ø)
ballista/rust/scheduler/src/state/mod.rs 70.49% <0.00%> (ø)
datafusion/src/physical_plan/expressions/case.rs 75.00% <0.00%> (-0.57%) ⬇️
...fusion/src/physical_plan/expressions/row_number.rs 81.25% <0.00%> (ø)
datafusion/src/physical_plan/repartition.rs 84.42% <ø> (-0.06%) ⬇️
benchmarks/src/bin/tpch.rs 30.84% <12.50%> (ø)
datafusion/src/execution/context.rs 92.00% <25.00%> (-0.09%) ⬇️
datafusion/src/physical_plan/windows.rs 86.46% <33.33%> (ø)
datafusion/src/physical_plan/hash_join.rs 84.89% <57.14%> (-0.63%) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad70a1e...f14084a. Read the comment docs.

@alamb
Copy link
Contributor

alamb commented Jun 13, 2021

Thank you @jimexist !

@alamb alamb merged commit 738f13b into apache:master Jun 13, 2021
@jimexist jimexist deleted the clippy-needless-borrow branch June 13, 2021 11:26
@houqp houqp added ballista datafusion Changes in the datafusion crate labels Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datafusion Changes in the datafusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants