Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement std::default::Default for execution config #570

Merged
merged 1 commit into from
Jun 18, 2021

Conversation

jimexist
Copy link
Member

Which issue does this PR close?

Closes #.

Rationale for this change

since most of the options are reasonable defaults we can have trait Default implemented

What changes are included in this PR?

Are there any user-facing changes?

@jimexist jimexist changed the title implement default for execution config implement std::default::Default for execution config Jun 16, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #570 (9dee39b) into master (51e5445) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #570   +/-   ##
=======================================
  Coverage   76.02%   76.02%           
=======================================
  Files         156      156           
  Lines       27063    27065    +2     
=======================================
+ Hits        20575    20577    +2     
  Misses       6488     6488           
Impacted Files Coverage Δ
datafusion/src/execution/context.rs 92.05% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51e5445...9dee39b. Read the comment docs.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice change; Thank you @jimexist

@alamb alamb merged commit e510bd6 into apache:master Jun 18, 2021
@jimexist jimexist deleted the impl-default-context branch June 18, 2021 14:33
@houqp houqp added datafusion Changes in the datafusion crate enhancement New feature or request labels Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datafusion Changes in the datafusion crate enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants