Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support modulus op #577

Merged
merged 1 commit into from
Jun 22, 2021
Merged

Support modulus op #577

merged 1 commit into from
Jun 22, 2021

Conversation

gangliao
Copy link
Contributor

@gangliao gangliao commented Jun 17, 2021

Which issue does this PR close?

apache/arrow-rs#98
#99
apache/arrow-rs#317

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@gangliao gangliao mentioned this pull request Jun 17, 2021
@gangliao
Copy link
Contributor Author

@alamb Thanks!

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @gangliao

I have triggered CI to start and if it is green I think this one is good to merge

@codecov-commenter
Copy link

Codecov Report

Merging #577 (29319f0) into master (51e5445) will increase coverage by 0.02%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #577      +/-   ##
==========================================
+ Coverage   76.02%   76.04%   +0.02%     
==========================================
  Files         156      156              
  Lines       27063    27071       +8     
==========================================
+ Hits        20575    20587      +12     
+ Misses       6488     6484       -4     
Impacted Files Coverage Δ
datafusion/src/physical_plan/expressions/binary.rs 90.66% <87.50%> (+1.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51e5445...29319f0. Read the comment docs.

@alamb alamb merged commit d55a105 into apache:master Jun 22, 2021
@houqp houqp added datafusion Changes in the datafusion crate enhancement New feature or request labels Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datafusion Changes in the datafusion crate enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants