feat: datafusion-cli support executes sql with escaped characters #6498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I merged this PR with the main branch to fix the build failure |
alamb
approved these changes
Jun 1, 2023
There was a problem hiding this comment.
This looks great -- thank you @r4ntix ❤️
I also tested the reproducer from the original report and it now works 🎉
❯ create external table test stored as csv location '/tmp/test.tsv' delimiter '\t';
0 rows in set. Query took 0.026 seconds.
❯ select * from test;
+----------+----------+
| column_1 | column_2 |
+----------+----------+
| col1 | col2 |
| 1 | 2 |
| } | ||
|
|
||
| #[test] | ||
| fn unescape_readline_input() -> Result<()> { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6397
Rationale for this change
See #6397
What changes are included in this PR?
unescape_inputfunction to unescape the input of datafusion-cliAre these changes tested?
Add unit tests in
src/helper.rsAre there any user-facing changes?
None