Fix Date32 and Date64 parquet row group pruning #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
force-pushed
the
alamb/fix_date32_pruning
branch
from
5baaf93
to
6d48968
Compare
alamb
commented
Jul 7, 2021
| @@ -900,6 +900,7 @@ impl TryFrom<ScalarValue> for i64 { | |||
| fn try_from(value: ScalarValue) -> Result<Self> { | |||
| match value { | |||
| ScalarValue::Int64(Some(inner_value)) | |||
| | ScalarValue::Date64(Some(inner_value)) | |||
There was a problem hiding this comment.
This mirrors the clause above for Date32 in TryFrom<ScalarValue> for i32
|
@yordan-pavlov this is ready for review. cc @Dandandan |
|
Thank you @Dandandan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Fixes: #649 as found by @yordan-pavlov
Build on #657 and #689 so please review them firstRationale for this change
Parquet pruning is not working for
Date32orDate64What changes are included in this PR?
Fixes parquet pruning on
Date32andDate64columns by adding the appropriate expression evaluation machinery for Date32 and Date64. Creating arrays for testing I found super awkward and I filed apache/arrow-rs#527 to try and track improving that situation