Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for primary key for external tables. #7161

Closed

Conversation

parkma99
Copy link
Contributor

Which issue does this PR close?

Closes #7154

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added sql SQL Planner logical-expr Logical plan and expressions core Core DataFusion crate labels Jul 31, 2023
@parkma99
Copy link
Contributor Author

parkma99 commented Jul 31, 2023

Hello @mustafasrepo , I don't know how to add Constraints in protobuf, Could you have some time to help me ? Thanks you!!!

@mustafasrepo
Copy link
Contributor

Hello @mustafasrepo , I don't know how to add Constraints in protobuf, Could you have some time to help me ? Thanks you!!!

Thanks for working on this issue. I have made a implementation that adds support for protobuf in here on top of your work. You can see the last commit. Basically, In short you have to update datafusion.proto file to add new protobuf types (with its own syntax). Once this file is updated, you have to run bash regen.sh script to automatically generate rust code. All the files under datafusion/proto/src/generated/ are automatically generated with this script. You shouldn't touch these files yourself. However, to add this support I had to make some structs under datafusion_common public. If you can come up with a solution where those structs doesn't have to be public. It would be very nice.

@parkma99
Copy link
Contributor Author

parkma99 commented Aug 1, 2023

Thanks @mustafasrepo

@github-actions github-actions bot added the sqllogictest SQL Logic Tests (.slt) label Aug 2, 2023
@parkma99 parkma99 marked this pull request as ready for review August 2, 2023 16:42
@parkma99 parkma99 marked this pull request as draft August 9, 2023 01:35
@parkma99 parkma99 closed this Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate logical-expr Logical plan and expressions sql SQL Planner sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for primary key for external tables.
2 participants