Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TimeUnit and IntervalUnit Copy #5839

Closed
hiltontj opened this issue Jun 3, 2024 · 1 comment · Fixed by #5840
Closed

Make TimeUnit and IntervalUnit Copy #5839

hiltontj opened this issue Jun 3, 2024 · 1 comment · Fixed by #5840
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers help wanted

Comments

@hiltontj
Copy link
Contributor

hiltontj commented Jun 3, 2024

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

The TimeUnit and IntervalUnit types in the arrow-schema crate are not Copy, but they are enums with only unit variants, so they should be cheaply Copy.

Describe the solution you'd like

Derive Copy for these types.

Describe alternatives you've considered

Can cheaply use clone, which is not the end of the world, but unless there is a reason to keep these types not-Copy, this would be an ergonomic improvement.

Additional context

N/A.

@hiltontj hiltontj added the enhancement Any new improvement worthy of a entry in the changelog label Jun 3, 2024
@alamb alamb added the arrow Changes to the arrow crate label Jul 2, 2024
@alamb
Copy link
Contributor

alamb commented Jul 2, 2024

label_issue.py automatically added labels {'arrow'} from #5840

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants