Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup ByteView construction #5878

Closed
XiangpengHao opened this issue Jun 13, 2024 · 2 comments · Fixed by #5879
Closed

Cleanup ByteView construction #5878

XiangpengHao opened this issue Jun 13, 2024 · 2 comments · Fixed by #5879
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog parquet Changes to the parquet crate

Comments

@XiangpengHao
Copy link
Contributor

Describe the solution you'd like

Now we have try_append_view, append_view_unchecked, and manual construction of ByteView in the code base.
We should clean up the implementation to be consistent and potentially more performant, specifically, avoiding manually build ByteView, use append_view_unchecked when we are sure it is safe.
@XiangpengHao XiangpengHao added the enhancement Any new improvement worthy of a entry in the changelog label Jun 13, 2024
@XiangpengHao XiangpengHao mentioned this issue Jun 13, 2024
Merged
@alamb alamb added the parquet Changes to the parquet crate label Jul 2, 2024
@alamb
Copy link
Contributor

alamb commented Jul 2, 2024

label_issue.py automatically added labels {'parquet'} from #5879

@alamb alamb added the arrow Changes to the arrow crate label Jul 2, 2024
@alamb
Copy link
Contributor

alamb commented Jul 2, 2024

label_issue.py automatically added labels {'arrow'} from #5879

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog parquet Changes to the parquet crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

clean up ByteView construction XiangpengHao/arrow-rs
2 participants
@alamb @XiangpengHao