Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement arrow-row en/decoding for GenericByteView types #5921

Closed
Tracked by #5374
XiangpengHao opened this issue Jun 20, 2024 · 2 comments · Fixed by #5922
Closed
Tracked by #5374

Implement arrow-row en/decoding for GenericByteView types #5921

XiangpengHao opened this issue Jun 20, 2024 · 2 comments · Fixed by #5922
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@XiangpengHao
Copy link
Contributor

XiangpengHao commented Jun 20, 2024 •
edited
Loading

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

I believe it is used in RowConverter, the code was triggered when trying to run tpc-h with StringView.

Reached unreachable code in https://github.com/apache/arrow-rs/blob/master/arrow-row/src/lib.rs#L1061
with StringViewArray.

Describe the solution you'd like

Implement it.

Describe alternatives you've considered

Additional context
@XiangpengHao XiangpengHao added the enhancement Any new improvement worthy of a entry in the changelog label Jun 20, 2024
@XiangpengHao
Copy link
Contributor Author

take

@XiangpengHao XiangpengHao changed the title Handle row_lengths for GenericByteView types Implement arrow-row support for GenericByteView types Jun 20, 2024
@XiangpengHao XiangpengHao changed the title Implement arrow-row support for GenericByteView types Implement arrow-row en/decoding for GenericByteView types Jun 20, 2024
@XiangpengHao XiangpengHao mentioned this issue Jun 20, 2024
Merged
@alamb alamb mentioned this issue Jun 20, 2024
Closed
31 tasks
@alamb alamb added the arrow Changes to the arrow crate label Jul 2, 2024
@alamb
Copy link
Contributor

alamb commented Jul 2, 2024

label_issue.py automatically added labels {'arrow'} from #5922

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement arrow-row encoding/decoding for view types XiangpengHao/arrow-rs
2 participants
@alamb @XiangpengHao