Implement Into<Arc<dyn Array>> for ArrayData

[ParkMyCar]

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

At a serialization layer I want to go from ArrayData to an Arc<dyn Array> and some logic higher up will downcast the Arc<dyn Array> into a specific type.

Describe the solution you'd like

Concrete array types, e.g. UInt32Array, implement From<ArrayData>. Implementing Into<Arc<dyn Array>> for ArrayData seems like it would be symmetrical.

Describe alternatives you've considered

The Array trait implements to_data(&self) -> ArrayData, maybe ArrayData could implement to_array(&self) -> Arc<dyn Array>

Additional context

Apologies if this is already possible, I couldn't find it in the docs

[alamb]

Seems like a nice improvement to me.

[tustvold]

There is a make_array method that does this

[ParkMyCar]

Perfect, make_array is what I was looking for! Do you think it would still be worthwhile to implement Into<Arc<dyn Array>> for ArrayData? If not, feel free to close out this issue!

[alamb]

Perfect, make_array is what I was looking for! Do you think it would still be worthwhile to implement Into<Arc<dyn Array>> for ArrayData? If not, feel free to close out this issue!

I think it would be worthwhile as it would make it more discoverable -- could you make a PR @ParkMyCar ?

[tustvold]

I could be mistaken, but I believe the orphan rules may prevent you from doing so

[ParkMyCar]

Perfect, make_array is what I was looking for! Do you think it would still be worthwhile to implement Into<Arc<dyn Array>> for ArrayData? If not, feel free to close out this issue!

I think it would be worthwhile as it would make it more discoverable -- could you make a PR @ParkMyCar ?

Yeah I'll whip this up! Hopefully orphan rules don't prevent it :)

[ParkMyCar]

Darn, yeah orphan rules and crate layout currently prevent it.

// approach 1 
//
// In the `arrow-data` crate, this doesn't work because `arrow-array` depends on `arrow-data`
// and we'd end up with a circular dependency.
impl Into<Arc<dyn Array>> for ArrayData { ... }

// approach 2
//
// In the `arrow-array` crate. I thought this would work, and it does if we used
// `Box<dyn Array>`, but `Arc` is not marked as "fundamental" like Box is.
//
// See: https://users.rust-lang.org/t/how-to-bypass-or-relax-orphan-rules/82999
impl From<ArrayData>  for Arc<dyn Array> { ... }

[alamb]

Thanks for trying 🙏