Add configuration option to StatisticsConverter to control interpretation of missing null counts in Parquet statistics
#6485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Oct 1, 2024
| @@ -2139,6 +2141,65 @@ async fn test_missing_statistics() { | |||
| .run(); | |||
| } | |||
|
|
|||
| #[test] | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #6256.
Rationale for this change
In #6257 @alamb changes the behavior of the parquet writer to always write
Some(0)when the null count is known to be zero. Part of #6257 allows users ofStatisticsConverterto choose whether or not to treat missing null counts as 0.What changes are included in this PR?
This PR consists of @alamb's changes to
StatisticsConverterwithout the changes to writer behavior. By default no behavior is changed, but users can prepare for later changes to how theStatistics::null_countfield is written.See the conversation here for the rationale.
Are there any user-facing changes?
No.