Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: fix local clippy using anon deprecated tonic-build API #6488

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Oct 1, 2024

Which issue does this PR close?

Closes #.

Rationale for this change

When I run clippy locally I seeing the following error:

error: use of deprecated method `tonic_build::Builder::compile_with_config`: renamed to `compile_protos_with_config()`
  --> arrow-flight/gen/src/main.rs:32:10
   |
32 |         .compile_with_config(prost_config(), &[proto_path], &[proto_dir])?;
   |          ^^^^^^^^^^^^^^^^^^^
   |
   = note: `-D deprecated` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(deprecated)]`

What changes are included in this PR?

Change the code to use the non deprecated API

Are there any user-facing changes?

No, this is an internal build script

@github-actions github-actions bot added arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate labels Oct 1, 2024
@alamb alamb added the development-process Related to development process of arrow-rs label Oct 1, 2024
Copy link
Contributor

@etseidl etseidl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirm I can run clippy now too. Thanks for this!

@alamb alamb merged commit d030177 into apache:master Oct 2, 2024
12 checks passed
@alamb
Copy link
Contributor Author

alamb commented Oct 2, 2024

Thanks @etseidl for the review

@alamb alamb deleted the alamb/fix_deprecation branch October 2, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate development-process Related to development process of arrow-rs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants