Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Fix path in format command in CONTRIBUTING.md #6494

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

etseidl
Copy link
Contributor

@etseidl etseidl commented Oct 1, 2024

Which issue does this PR close?

N/A

Rationale for this change

The instructions for running cargo fmt on the parquet crate will scan too many files.

What changes are included in this PR?

Change instructions so only the parquet directory will be traversed.

Are there any user-facing changes?

No, documentation change only.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thank you @etseidl

@alamb
Copy link
Contributor

alamb commented Oct 2, 2024

I double checked that the corresponding CI job doesn't need to be changed too

working-directory: parquet
run: cargo fmt -p parquet -- --check --config skip_children=true `find . -name "*.rs" \! -name format.rs`

I believe it does not need a change as it already has a working-directory set to parquet

@alamb alamb merged commit c54f942 into apache:master Oct 2, 2024
9 checks passed
@etseidl etseidl deleted the contrib_fix branch October 2, 2024 18:07
@alamb alamb added the development-process Related to development process of arrow-rs label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development-process Related to development process of arrow-rs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants