Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove reliance on raw-entry feature of Hashbrown #6498

Closed
Jefffrey opened this issue Oct 2, 2024 · 3 comments · Fixed by #6537
Closed

Remove reliance on raw-entry feature of Hashbrown #6498

Jefffrey opened this issue Oct 2, 2024 · 3 comments · Fixed by #6537
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate enhancement Any new improvement worthy of a entry in the changelog parquet Changes to the parquet crate

Comments

@Jefffrey
Copy link
Contributor

Jefffrey commented Oct 2, 2024

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

When upgrading to hashbrown v0.15.0: #6493

Changelog notes:

Raw entry API is now under raw-entry feature, to be eventually removed

https://github.com/rust-lang/hashbrown/blob/master/CHANGELOG.md#v0150---2024-10-01

Describe the solution you'd like

Remove reliance on this feature so future upgrades to hashbrown versions will be smooth

arrow-rs/parquet/src/util/interner.rs

Line 19 in 581c647

use hashbrown::hash_map::RawEntryMut;

arrow-rs/arrow-array/src/builder/generic_bytes_dictionary_builder.rs

Line 23 in 581c647

use hashbrown::hash_map::RawEntryMut;

Describe alternatives you've considered

Additional context
@Jefffrey Jefffrey added the enhancement Any new improvement worthy of a entry in the changelog label Oct 2, 2024
@Jefffrey Jefffrey mentioned this issue Oct 2, 2024
Closed
@tustvold tustvold mentioned this issue Oct 10, 2024
Merged
@alamb alamb added the parquet Changes to the parquet crate label Oct 20, 2024
@alamb
Copy link
Contributor

alamb commented Oct 20, 2024

label_issue.py automatically added labels {'parquet'} from #6537

@alamb alamb added the arrow Changes to the arrow crate label Oct 20, 2024
@alamb
Copy link
Contributor

alamb commented Oct 20, 2024

label_issue.py automatically added labels {'arrow'} from #6537

@alamb alamb added the arrow-flight Changes to the arrow-flight crate label Oct 20, 2024
@alamb
Copy link
Contributor

alamb commented Oct 20, 2024

label_issue.py automatically added labels {'arrow-flight'} from #6493

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate enhancement Any new improvement worthy of a entry in the changelog parquet Changes to the parquet crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use HashTable instead of raw_entry_mut tustvold/arrow-rs
2 participants
@alamb @Jefffrey