[C++] Build errors with Visual Studio 2019

[asfimport]

On September 10 the test-build-vcpkg-win nightly Crossbow job began to fail.

This job uses the current windows-2019 GHA runner image, so it often catches build errors associated with Visual Studio/MSVC updates.

The logs show these error messages (simplified for readability):

compute/util_internal.h(26,20): warning C4003: not enough arguments for function-like macro invocation 'RtlZeroMemory'
compute/util_internal.h(26,20): error C2146: syntax error: missing ')' before identifier 'buffer'
compute/util_internal.h(26,20): error C2065: 'buffer': undeclared identifier
compute/util_internal.h(26,20): error C2182: 'memset': illegal use of type 'void'
compute/util_internal.h(26,20): error C7525: inline variables require at least '/std:c++17'
compute/util_internal.h(26,20): error C2059: syntax error: 'constant'
compute/util_internal.h(26,20): error C2059: syntax error: ')'
compute/util_internal.h(26,47): error C2143: syntax error: missing ';' before '{'
compute/util_internal.h(26,47): error C2447: '{': missing function header (old-style formal list?)

Here is a link to the logs when they first began to fail on September 10: https://github.com/ursacomputing/crossbow/runs/3564248552#step:4:2985
The error messages have remained the same since then.

Here is a link to the logs from the previous day (September 9) before they began to fail:
https://github.com/ursacomputing/crossbow/runs/3552742330

 

Possible causes include:

Updates to MSVC that were applied to the  windows-2019 GHA runner image on September 9:
actions/runner-images#3452

One of these commits on September 9:
https://github.com/apache/arrow/search?o=desc&p=1&q=committer-date%3A2021-09-09&s=author-date&type=commits

Changes to one of the vcpkg-installed Arrow dependencies on September 9 (but I don't see any such changes in the microsoft/vcpkg repo commit history).

Reporter: Ian Cook / @ianmcook
Assignee: Antoine Pitrou / @pitrou

PRs and other links:

• GitHub Pull Request #11303

_{Note: This issue was originally created as ARROW-14208. Please see the migration documentation for further details.}

[asfimport]

Ian Cook / @ianmcook:
@pitrou  could you take a look at this? Thank you

[asfimport]

Antoine Pitrou / @pitrou:
Issue resolved by pull request 11303
#11303