Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-40937: [Java] Implement Holder-based functions for ViewVarCharVector #44187

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

GH-40937: [Java] Implement Holder-based functions for ViewVarCharVector #44187

wants to merge 3 commits into from
+114 −13

Conversation

ViggoC
Copy link
Contributor

@ViggoC ViggoC commented Sep 23, 2024 •
edited by github-actions bot
Loading

@ViggoC ViggoC marked this pull request as ready for review September 23, 2024 08:14
@ViggoC
Copy link
Contributor Author

ViggoC commented Sep 23, 2024

@vibhatha @lidavidm Could you review this PR?

vibhatha
vibhatha reviewed Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@vibhatha vibhatha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments. Thanks for starting this work.

java/vector/src/main/java/org/apache/arrow/vector/ViewVarCharVector.java Outdated Show resolved Hide resolved
java/vector/src/test/java/org/apache/arrow/vector/TestVarCharViewVector.java Outdated

NullableViewVarCharHolder stringHolder = new NullableViewVarCharHolder();

setAndCheck(viewVarCharVector, 1, strings.get(0), stringHolder);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To check overwrite?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this? Could you explain a bit?

Copy link
Contributor Author

@ViggoC ViggoC Sep 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's not needed. I just missed it while adjusting the code. But you reminded me that it is necessary to add some overwrite test cases.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it is a must. It is okay to leave it at this moment.

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Sep 23, 2024
vibhatha
vibhatha approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@vibhatha vibhatha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR LGTM. Just a few minor suggestions.
Thanks for working on this.

java/vector/src/main/java/org/apache/arrow/vector/ViewVarCharVector.java Outdated Show resolved Hide resolved
java/vector/src/main/java/org/apache/arrow/vector/ViewVarCharVector.java Outdated Show resolved Hide resolved
@vibhatha
Copy link
Collaborator

@lidavidm PR LGTM, please take a look.

@ViggoC
Copy link
Contributor Author

ViggoC commented Sep 25, 2024

PR LGTM. Just a few minor suggestions. Thanks for working on this.

Thanks for your review.

@ViggoC
Copy link
Contributor Author

ViggoC commented Sep 25, 2024 •
edited
Loading

@vibhatha @lidavidm I think the code to support ViewVarBinaryHolder is almost a duplicate of this PR. Do you prefer to fix it in this one or submit another PR.

@vibhatha
Copy link
Collaborator

@ViggoC let's do it here.

@lidavidm
Copy link
Member

Whichever is easier for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vibhatha vibhatha vibhatha approved these changes

@lidavidm lidavidm Awaiting requested review from lidavidm lidavidm is a code owner

Assignees
No one assigned
Labels
awaiting committer review Awaiting committer review Component: Java
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ViggoC @vibhatha @lidavidm