Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Support NamedTuples/Dataclass for perf alert tests configuration #28395

Closed
1 of 15 tasks
AnandInguva opened this issue Sep 11, 2023 · 0 comments · Fixed by #28889
Closed
1 of 15 tasks

[Task]: Support NamedTuples/Dataclass for perf alert tests configuration #28395

AnandInguva opened this issue Sep 11, 2023 · 0 comments · Fixed by #28889
Labels
done & done Issue has been reviewed after it was closed for verification, followups, etc. P3 perf-alert Automatically filed performance-related alerts. python task
Milestone
2.52.0 Release

Comments

@AnandInguva
Copy link
Contributor

What needs to happen?

Right now, for perf alerts, the tests are defined in a yaml file.

I think it would be good to support a NamedTuple or Dataclass to define the data that is required to run a perf analysis tool.

Issue Priority

Priority: 3 (nice-to-have improvement)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@AnandInguva AnandInguva added task perf-alert Automatically filed performance-related alerts. labels Sep 11, 2023
@AnandInguva AnandInguva mentioned this issue Oct 9, 2023
Merged
3 tasks
@github-actions github-actions bot added this to the 2.52.0 Release milestone Oct 10, 2023
@jrmccluskey jrmccluskey added the done & done Issue has been reviewed after it was closed for verification, followups, etc. label Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
done & done Issue has been reviewed after it was closed for verification, followups, etc. P3 perf-alert Automatically filed performance-related alerts. python task
Projects
None yet
Milestone
2.52.0 Release
Development

Successfully merging a pull request may close this issue.

Add dataclasses to perf alert tool and refactor code. AnandInguva/beam
2 participants
@AnandInguva @jrmccluskey